Daniel/hotel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed: Module list incomplete XML error on back office

Browse Source 
Co-authored-by: Name <sumit201@webkul.in>
This commit is contained in:
shazar rahman
2026-10-12 16:08:24 +05:30
parent df93538090
commit b2f7f50d64
2 changed files with 21 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
classes/module/Module.php
View File

@@ -1773,6 +1773,23 @@ abstract class ModuleCore
return Db::getInstance()->executeS($sql);
}
/**
* Writes downloaded XML to a cache file only when it parses, so a truncated
* response never replaces a good cache file.
*
* @param string $cacheFile Cache file path relative to _PS_ROOT_DIR_
* @param string|bool $xmlContent Downloaded content, false when the request failed
* @return bool True if the content was valid and written
*/
protected static function saveValidXmlCache($cacheFile, $xmlContent)
{
if (!$xmlContent || !@simplexml_load_string($xmlContent)) {
return false;
}
return (bool) file_put_contents(_PS_ROOT_DIR_.$cacheFile, $xmlContent);
}
public static function refreshModuleList($force_reload_cache = false)
{
$status = false;
@@ -1792,7 +1809,7 @@ abstract class ModuleCore
if ($status != 'error') {
if (!Tools::isFresh(Module::CACHE_FILE_DEFAULT_COUNTRY_MODULES_LIST, _TIME_1_DAY_) || $force_reload_cache) {
if (file_put_contents(_PS_ROOT_DIR_.Module::CACHE_FILE_DEFAULT_COUNTRY_MODULES_LIST, Tools::addonsRequest('native'))) {
if (Module::saveValidXmlCache(Module::CACHE_FILE_DEFAULT_COUNTRY_MODULES_LIST, Tools::addonsRequest('native'))) {
$status = 'refresh';
} else {
$status = 'error';
@@ -1804,7 +1821,7 @@ abstract class ModuleCore
if ($status != 'error') {
if (!Tools::isFresh(Module::CACHE_FILE_MUST_HAVE_MODULES_LIST, _TIME_1_DAY_) || $force_reload_cache) {
if (file_put_contents(_PS_ROOT_DIR_.Module::CACHE_FILE_MUST_HAVE_MODULES_LIST, Tools::addonsRequest('must-have'))) {
if (Module::saveValidXmlCache(Module::CACHE_FILE_MUST_HAVE_MODULES_LIST, Tools::addonsRequest('must-have'))) {
$status = 'refresh';
} else {
$status = 'error';
@@ -1816,7 +1833,7 @@ abstract class ModuleCore
if ($status != 'error') {
if (!Tools::isFresh(Module::CACHE_FILE_ADDONS_MODULES_LIST, _TIME_1_DAY_) || $force_reload_cache) {
if (file_put_contents(_PS_ROOT_DIR_.Module::CACHE_FILE_ADDONS_MODULES_LIST, Tools::addonsRequest('addons-modules'))) {
if (Module::saveValidXmlCache(Module::CACHE_FILE_ADDONS_MODULES_LIST, Tools::addonsRequest('addons-modules'))) {
$status = 'refresh';
} else {
$status = 'error';