From 25bf92679f7496dfec78dff38ec5ddf9bd1c4a34 Mon Sep 17 00:00:00 2001 From: amit sharma Date: Thu, 24 Sep 2026 18:10:01 +0530 Subject: [PATCH] Fixed: Prevent connecting rooms from different hotels by changing room ID Co-authored-by: Name --- .../template/controllers/products/configuration.tpl | 8 ++++---- controllers/admin/AdminProductsController.php | 13 +++++++++++++ 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/admin-dev/themes/default/template/controllers/products/configuration.tpl b/admin-dev/themes/default/template/controllers/products/configuration.tpl index 4d88277f5..62fd6c906 100644 --- a/admin-dev/themes/default/template/controllers/products/configuration.tpl +++ b/admin-dev/themes/default/template/controllers/products/configuration.tpl @@ -2005,7 +2005,7 @@ $('#connected_room_title').html(''); } } else { - alert(response.message); + showErrorMessage(response.message); } } }); @@ -2016,7 +2016,7 @@ var connectedRoomId = $row.find('.connect-room').val(); if (!connectedRoomId) { - alert(selectRoomText); + showErrorMessage(selectRoomText); return; } $.ajax({ @@ -2043,7 +2043,7 @@ $icon.text(response.connected_count); } } else { - alert(response.message); + showErrorMessage(response.message); } }, complete: function() { @@ -2132,7 +2132,7 @@ $icon.text(response.connected_count); } } else { - alert(response.message); + showErrorMessage(response.message); } } }); diff --git a/controllers/admin/AdminProductsController.php b/controllers/admin/AdminProductsController.php index bd8a07335..f3d68dad1 100644 --- a/controllers/admin/AdminProductsController.php +++ b/controllers/admin/AdminProductsController.php @@ -5715,6 +5715,19 @@ class AdminProductsControllerCore extends AdminController $idHotel = (int) $objRoom->id_hotel; if ($mode === 'add') { + if (!Validate::isLoadedObject($objRoom)) { + die(json_encode(['success' => false, 'message' => $this->l('Invalid room selected.')])); + } + + $objConnectedRoom = new HotelRoomInformation($connectedRoomId); + if ( + $connectedRoomId === $roomId + || !Validate::isLoadedObject($objConnectedRoom) + || (int) $objConnectedRoom->id_hotel !== $idHotel + ) { + die(json_encode(['success' => false, 'message' => $this->l('Invalid room selected for connection.')])); + } + $connection = new HotelConnectedRoom(); $connection->id_room = $roomId; $connection->id_room_connected = $connectedRoomId;